hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line
https://pypi.org/project/starcli/
MIT License
547 stars 50 forks source link

Use gtrending for fetching GitHub trending instead of scraping the web #86

Closed odmishien closed 3 years ago

odmishien commented 3 years ago

resolves #82

Checklist

Description

odmishien commented 3 years ago

@hedythedev Thank you for your review! I fixed it. And I can't understand why test was failed, because I couldn't find out the test assert 0 == 1 in our code. Would you know what's going on?

=================================== FAILURES ===================================
______________________________ test_search_stars _______________________________

    def test_search_stars():
        """
        Test the search functionality for starcli.search.
        """
        repos = search(language="python", stars="1")
        for repo in repos:
>           assert repo["stargazers_count"] == 1
E           assert 0 == 1

tests/test_search.py:114: AssertionError
odmishien commented 3 years ago

@hedythedev Thank you for your review! I fixed it 🔧

hedyhli commented 3 years ago

@allcontributors please add @odmishien for code

allcontributors[bot] commented 3 years ago

@hedythedev

I've put up a pull request to add @odmishien! :tada: