Added support for caching results

hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line

https://pypi.org/project/starcli/

MIT License

547 stars 50 forks source link

Added support for caching results #97

Closed AkashD-Developer closed 3 years ago

AkashD-Developer commented 3 years ago

Checklist

[X] My code is properly formatted using the latest black
[ ] I have added/updated tests if needed
[X] I have tried running my code manually
[X] I have checked for spelling errors

Description Resolves #61 Added support to cache the responses to a JSON file which will get created when the user first runs the program and also added it to .gitignore so that it will not be tracked by git.

The cache file looks something like this after few requests

Those are the keys, which contains the content of the responses.

hedyhli commented 3 years ago

hello, thank you for your pr! I will take a look when I have time, hopefully before the end of next week.

AkashD-Developer commented 3 years ago

Thanks, Hedy. Glad to hear back from you. Will be waiting for the review.

hedyhli commented 3 years ago

@allcontributors please add @AkashD-Developer for code

allcontributors[bot] commented 3 years ago

@hedythedev

I've put up a pull request to add @AkashD-Developer! :tada:

AkashD-Developer commented 3 years ago

Hey Hedy, thank you so much. I would love to contribute more if there’s anything else you require help for.

hedyhli commented 3 years ago

No problem, feel free to do the tests ^

AkashD-Developer commented 3 years ago

Hey @hedythedev, sure I will take up the new issue. I was actually thinking of some tests for it but was unable to come up with anything. Thanks for the ideas 👍