search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.32k stars 289 forks source link

[CLEAN-UP] Make quiz completely dependent on tailwind classes for styling #2797

Closed TiBiBa closed 2 years ago

TiBiBa commented 2 years ago

Describe the issue We currently have some manual written CSS for the quiz styling. This is not necessary as we can achieve the same styling with Tailwind classes. Might also be a good first issue to get familiar with our code base and Tailwind in general!

bhlox commented 2 years ago

I would like to work on this issue. But, I am currently having issues with running it locally.

I've followed the instructions with installing it via windows PowerShell. When it comes to running website version locally command, I'm currently encountering issues.

image

TiBiBa commented 2 years ago

I would like to work on this issue. But, I am currently having issues with running it locally.

I've followed the instructions with installing it via windows PowerShell. When it comes to running website version locally command, I'm currently encountering issues.

image

Awesome, thanks for picking up this issue! These logs are as expected when the server is running and it seems to be working fine. Did you try navigating to http://0.0.0.0:8080 in your web browser? You should be able to visit your locally running server there.

bhlox commented 2 years ago

Yes I did try to navigate to the URL. But all I get is this page.

image

TiBiBa commented 2 years ago

Yes I did try to navigate to the URL. But all I get is this page.

image

Weird! What IDE are you using? And do you console logs change when trying to reach the page?

bhlox commented 2 years ago

Hold on, I manage to solve it. You could put it on the documentation (for newbs like me) That if URL "http://0.0.0.0:8080/" doesn't work, they can do this "http://localhost:8080".

Reference to where i find other issues: https://stackoverflow.com/questions/43547420/python-server-http-0-0-0-08080

anywho, is the issue to be worked on is the quiz.html?

TiBiBa commented 2 years ago

Hold on, I manage to solve it. You could put it on the documentation (for newbs like me) That if URL "http://0.0.0.0:8080/" doesn't work, they can do this "http://localhost:8080".

Reference to where i find other issues: https://stackoverflow.com/questions/43547420/python-server-http-0-0-0-08080

anywho, is the issue to be worked on is the quiz.html?

Awesome, nice that you got it working! The issue is related to all quiz related templates. These are all stored in the /templates/quiz folder. The issue is that all these templates are partly dependent on the /css/quiz-css.css file for styling. We would like to remove this dependency and make these templates dependent on our Tailwind CSS library, just like all other templates. All specific styling that can't be covered by Tailwind should be stored in css/additional.css or built-tools/heroku/tailwind/styles.css.

Let me know if you need any help! The CONTRIBUTING.md file has a short explanation on how to work with Tailwind.

bhlox commented 2 years ago

Cool. is there a more convenient way of contacting you or messaging you? (e.g. discord, facebook)

TiBiBa commented 2 years ago

Cool. is there a more convenient way of contacting you or messaging you? (e.g. discord, facebook)

We just created a Discord channel to get in touch with contributors. Feel free to message me there or ask any question in the related channels. You can join through this link: https://discord.gg/8yY7dEme9r.

Felienne commented 2 years ago

Hold on, I manage to solve it. You could put it on the documentation (for newbs like me) That if URL "http://0.0.0.0:8080/" doesn't work, they can do this "http://localhost:8080".

That is a good point, @TiBiBa, can you do that or make an issue so we don't forget?

TiBiBa commented 2 years ago

Hold on, I manage to solve it. You could put it on the documentation (for newbs like me) That if URL "http://0.0.0.0:8080/" doesn't work, they can do this "http://localhost:8080".

That is a good point, @TiBiBa, can you do that or make an issue so we don't forget?

Will do!