[FEATURE] Show translation switcher for some users

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.

https://www.hedy.org

European Union Public License 1.2

1.32k stars 289 forks source link

[FEATURE] Show translation switcher for some users #4420

Closed Felienne closed 11 months ago

Felienne commented 1 year ago

In https://github.com/hedyorg/hedy/pull/3327 we made it so that only the admin sees the translation option in the editor:

But @Mark-Giesen would like to use it as a teacher also. I am open to the idea but the reason we removed it was that it is a bit much to show for student users. I would prefer an option in your profile to enable this (maybe only visible for teacher users)

What do you all think?

Mark-Giesen commented 1 year ago

There is another option, which is still available to all: the language selector in the cheatsheet. Was this meant as a replacement for this switcher in the editor, or are the use cases different? We discussed a similar feature once: change the created code into generic code, so replacing all commands with the {} placeholders. This way translators could easily try code and once ready, transform it without typos into YAML text. These options might be combined by having three options available for certain people/settings: EN/selected/generic languages.

Mark-Giesen commented 1 year ago

See #2573 for the feature mentioned above.

Felienne commented 1 year ago

After more discussion with @Mark-Giesen, we have a plan forward!!

The keyword switcher, that we already support:

should just also translate the code in the code box. In essence I think this is a simple fix, which could be done more or less like this:

Remove the switcher for the admin (see #3327 that removes it for all other users)
Make sure the UI does not switch to the first tab (I do not know what causes this, we can also do that separately)
Call translate_keywords() on the program in the editor

Maybe @Mark-Giesen would like to pick this up (I think it is easier maybe than the yaml generator)

Mark-Giesen commented 1 year ago

Maybe @Mark-Giesen would like to pick this up (I think it is easier maybe than the yaml generator)

I'm happy to take on both, but it will take some weeks before I have some spare time. End of first quarter coming up, some work deadlines to consider.

Felienne commented 1 year ago

No rush!! Happy to see your contribution when you have time.

Felienne commented 1 year ago

We discussed this in the meeting today and we have a path forward:

Make the top switcher translate the program too (Felienne can pcik that up, she thinks haha)
Remove the switcher in the editor
Show the top switcher, also when people are logged in, so they can use the button to switch it
Rename the top switcher, so that it does not show the translation emoji, but the current keyword language (so: en or nl)

btw this is what I mean with the top switcher:

Felienne commented 1 year ago

I wil do a few first steps and check back in if I need help