[BUG] language switcher switches back

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.

https://www.hedy.org

European Union Public License 1.2

1.29k stars 284 forks source link

[BUG] language switcher switches back #4579

Closed AnneliesVlaar closed 11 months ago

AnneliesVlaar commented 11 months ago

If the preferred commando language is English and the url is similar to this: https://hedycode.com/hedy#default (it happens in every level) the language switchers is switched to English. If I then use the language switcher to switch to Dutch (the preferred language), the switcher switches back to English at once and the url changes to: https://hedycode.com/hedy?keyword_language=en#default . From this point on the switcher works as intended.

Felienne commented 11 months ago

This might also be a nice front-end fix for @hasan-sh? (Like the drop downs that don't close)

Felienne commented 11 months ago

HI @AnneliesVlaar!

Me and @hasan-sh are looking into this issue, and I know you showed the issue in the previous meeting, but I can't remember how to reproduce it and from the description we can't figure it out. Would you mind explaining it in a bit more detail or recording a video?

I think our confusion starts with "If the preferred commando language is English ... the language switchers is switched to English. " because if your preferred commando language is English, there is no switcher?

Thanks!!

yilmazdurmaz commented 11 months ago

to reproduce:

in "my account", open "my personal settings"
change "Preferred language" to something other than English
set "Preferred keyword language" to English
switch to adventures (Hedy) and URL gets to be {host}/hedy#default
open language switcher, swtich language, URL becomes /hedy?keyword_language=en#default
- the first time you do this, it still stays being English
- you have to hit the switcher a second time

whenever you visit other pages while the keyword language is last set to English, then this repeats: you have to hit twice to actually switch the keyword language.

AnneliesVlaar commented 11 months ago

Hi @Felienne ,

The bug is only working in specific conditions ;-) Here is a screenrecording:

https://github.com/hedyorg/hedy/assets/66774020/4e88bfbd-5f98-4af1-a939-ae9c2ba4da4c

hasan-sh commented 11 months ago

Thanks @AnneliesVlaar and @yilmazdurmaz for clarifying the issue. It should be fixed by #4647 :)