search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.27k stars 282 forks source link

💻 new customize adventure page #5535

Open hasan-sh opened 1 month ago

hasan-sh commented 1 month ago

Fixes https://github.com/hedyorg/hedy/issues/5086

hasan-sh commented 1 month ago

@Felienne as discussed in the meeting, we need to decide what descriptions we want to put in the solution example and tips tabs:

image

NB: the solution example has the editor and the tips is empty!

hasan-sh commented 6 days ago

@jpelay I like and agree with all suggestions!

hasan-sh commented 6 days ago

Will disable the tips section for now until it's needed and known what content to put in there!

Felienne commented 6 days ago

Will disable the tips section for now until it's needed and known what content to put in there!

Disabling seems a bit of a heavy strategy?

Felienne commented 6 days ago

Will disable the tips section for now until it's needed and known what content to put in there!

Disabling seems a bit of a heavy strategy?

I think we want something along the lines of: "Here you can add tips to help other teachers help their students"?

hasan-sh commented 6 days ago

I think we want something along the lines of: "Here you can add tips to help other teachers help their students"?

Sure. How would creating tips look like? Where and how do we list or represent them?

Disabling seems a bit of a heavy strategy?

I didn't get any note about it!! Also i thought we could implement it in a separate PR in accordance with the new hedy design that's being created!

Felienne commented 6 days ago

I think we want something along the lines of: "Here you can add tips to help other teachers help their students"?

Sure. How would creating tips look like? Where and how do we list or represent them?

I am lost here, sorry. In the screenshot above, there is already a tab called "tips". I thought you were looking for text to put there to expain what the tips are for. Help me understand what text you need and I can provide it to you.

Please remember I have not looked at this PR, so if you need my input, you need to sketch a bit of context and ask me clear questions (Or ask Jesus, he has seen more of this work, and I am sure he has great ideas too!)

I didn't get any note about it!!

I think this has to do with the fact that I don't really understand the question well (again, I have not looked at the PR, just jumping in for being tagged) But surely we can do it in a different PR is that makes more sense, just open an issue so we don't forget.

hasan-sh commented 6 days ago

Well, the mention was in May after i presented the latest status of this PR and you said you'd write more info about how the tips section would look like. So, I guess the main point is that do you want the tips to be created within an editor as well? Or just a simple textarea?

It just needs some thought to avoid confusion, because if you choose for an editor, there'd be 3 editors in this page!

But surely we can do it in a different PR is that makes more sense, just open an issue so we don't forget.

Will do!

Felienne commented 6 days ago

I guess the main point is that do you want the tips to be created within an editor as well? Or just a simple textarea? It just needs some thought to avoid confusion, because if you choose for an editor, there'd be 3 editors in this page!

Ok this is a clear question I can answer with ease: I want it to be a simple text box! I had read the confusion as one about content, and thus not understood it. But now you are explaining it well, you are giving alternative options (editor or text) with pros and cons, which is super useful, that really helps me answer quickly!

My related question is: how are we going to show the tips, and the model solutions to teachers that want to use the adventures, have we got a plan for that?

Felienne commented 6 days ago

(oops clicked the wrong button when commenting)

Felienne commented 1 day ago

And on a whole different note, I don't really agree with the design of the tabs. Not only because the new design for the Hedy tabs is not implemented yet, so until then teachers might be very confused. But still I think this can be done in a more understandable way. @Felienne @gisellandrade what do you think? Just addressing this now, but can of course be done in a different PR.

Hi @Annelein!

Do you want to make changes to these tabs (that are a bit different from the adventure tabs, because they are here representing different aspects of an adventure)? I am open to looking at what you want it to look like, but I can also imagine we redesign this with the new homepage together.

Annelein commented 18 hours ago

Do you want to make changes to these tabs (that are a bit different from the adventure tabs, because they are here representing different aspects of an adventure)? I am open to looking at what you want it to look like, but I can also imagine we redesign this with the new homepage together.

Hi @Felienne ! I think it should be a different than the adventure tabs design, so not redesign it with the homepage but septeratly. Because these aren't adventure tabs but they have a whole different meaning/purpose right? Let me know if you get what I mean.

I was thinking something like this for example: Screenshot 2024-07-02 at 13 49 16

Annelein commented 18 hours ago

Hey @hasan-sh ! Looks good, I've added a few comments and was wondering, is the whole page covered in the Cypress tests now?

@hasan-sh what about the Cypress tests?

hasan-sh commented 17 hours ago

Hi @Felienne ! I think it should be a different than the adventure tabs design, so not redesign it with the homepage but septeratly. Because these aren't adventure tabs but they have a whole different meaning/purpose right? Let me know if you get what I mean.

I was thinking something like this for example: Screenshot 2024-07-02 at 13 49 16

I like this since it aligns more with the new redesign, do you wanna push your commit here before we merge?