search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.26k stars 282 forks source link

🧪 Update test db #5539

Closed Annelein closed 3 weeks ago

Annelein commented 1 month ago

Fixes #5522

How to test See if teacher1 now has programs and a public profile

Annelein commented 1 month ago

@Felienne this test fails: second-teachers can NOT view each other's public programs because teacher1 now has public programs and teacher4 can actually see them. So I don't think this was a properly working test before?

But did we change this, are second teachers allowed to view each other's public programs now? Or does this PR catch an issue?

Felienne commented 1 month ago

@Felienne this test fails: second-teachers can NOT view each other's public programs because teacher1 now has public programs and teacher4 can actually see them. So I don't think this was a properly working test before?

Ah good find!! The immediate effects of more test data :)

But did we change this, are second teachers allowed to view each other's public programs now? Or does this PR catch an issue?

I don't think this change was intentional, but maybe @jpelay or @hasan-sh knows?

hasan-sh commented 1 month ago

@Felienne this test fails: second-teachers can NOT view each other's public programs because teacher1 now has public programs and teacher4 can actually see them. So I don't think this was a properly working test before?

This test isn't failing on master and passing as expected, but i see you added two public programs, not sure why, but then you need to adjust the tests accordingly. For instance, https://github.com/hedyorg/hedy/blob/main/tests/cypress/e2e/public_programs/programs_page.cy.js#L141 wouldn't hold anymore!

But did we change this, are second teachers allowed to view each other's public programs now? Or does this PR catch an issue?

Second teachers can do different things; see here https://github.com/hedyorg/hedy/pull/4644

mergify[bot] commented 3 weeks ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).