search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.26k stars 282 forks source link

🪲 Improve long program warning for sleep programs and increase time #5576

Closed Felienne closed 1 month ago

Felienne commented 1 month ago

Fixes #5399

In https://github.com/hedyorg/hedy/pull/5277 we introduced a sleep prompt, but accidentally we now now longer detect sleeps in levels below 7, causing them to quickly stop (annoying!) Maybe that was even the reason people were reporting #5399 but I upped the limits a bit too.

Felienne commented 1 month ago

Hi @Annelein!

I think I made the frontend fix correctly but I am not sure, can you check and approve if this makes sense (and improve otherwise 🤣 )

Annelein commented 1 month ago

@Felienne I think it looks good! But maybe because I did not know of a better/easier way to do this 😅, I don't think I am the most experienced for this PR? So maybe best if @jpelay has a look as well?

Felienne commented 1 month ago

@Felienne I think it looks good! But maybe because I did not know of a better/easier way to do this 😅, I don't think I am the most experienced for this PR? So maybe best if @jpelay has a look as well?

Yeah I figured that! it was smartly done working around the parser like that!

If will you are ok with merging this, I will re-open the sleep prompt one and we will ask Jesus to do it with Skulpt!

mergify[bot] commented 1 month ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).