search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.3k stars 285 forks source link

🪲 Fixes accessing deleted tags on adventure #5580

Closed jpelay closed 4 months ago

jpelay commented 4 months ago

Checks if the tag is different than None.

Fixes #5579

How to test

The best way would be to open an adventure, add a tag, and then delete it in the DB. Reload the server and you should be able to keep editing the adventure.

hasan-sh commented 4 months ago

Can we instead do the check here to make it generic? https://github.com/hedyorg/hedy/blob/8be93ffb65da2aeb47142092f375c97b76326efe/website/database.py#L597

if name

jpelay commented 4 months ago

Can we instead do the check here to make it generic?

https://github.com/hedyorg/hedy/blob/8be93ffb65da2aeb47142092f375c97b76326efe/website/database.py#L597

if name

Done

mergify[bot] commented 4 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] commented 4 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).