🪲 Fix error page - Githubissues

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.

https://www.hedy.org

European Union Public License 1.2

1.26k stars 281 forks source link

🪲 Fix error page #5612

Closed jpelay closed 2 weeks ago

jpelay commented 2 weeks ago

The error page was failing because it was trying to retrieve an image that wasn't there.

Fixes #5598

How to test

Follow these steps to verify this PR works as intended:

Go to http://127.0.0.1:5000/hedy/a24e2453366248fb9359fffa3089d209/view whilst logged out and see that the image and the message is shown.

Felienne commented 2 weeks ago

Thanks for fixing!! I am puzzled though how did this got broken? Did we rename the image?

jpelay commented 2 weeks ago

Thanks for fixing!! I am puzzled though how did this got broken? Did we rename the image?

No, we added a new error type and didn't check that it had an image, so I'm using an existing now.

mergify[bot] commented 2 weeks ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).