🧹 Tags: remove double get, sort tags

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.

https://www.hedy.org

European Union Public License 1.2

1.3k stars 285 forks source link

🧹 Tags: remove double get, sort tags #5620

Closed rix0rrr closed 3 months ago

rix0rrr commented 3 months ago

Two tiny changes ported over from #5431:

Remove a duplicate database retrieval when looking up the tags of an adventure.
Sort the tags (when they are saved to the database).

How to test

Unsorted tags should be sorted after adding a tag. Otherwise no functional difference.

Felienne commented 3 months ago

Hi @rix0rrr!

This has a failing Cypress test that I suspects fails for good reasons, can you take a look?

mergify[bot] commented 3 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] commented 3 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).