search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.3k stars 285 forks source link

🪲 Add curly braces around `add ... to` command #5625

Closed jpelay closed 3 months ago

jpelay commented 3 months ago

If you used the add command in one of the adventures, when adding the curly braces it was translated as {add} el {toList} l which caused the problem of the adventure not being shown correctly since toList is not the name of the keyword on our translation dictionaries. I changed the name of the keyword in the grammars.

How to test

I added a test for this scenario.

mergify[bot] commented 3 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] commented 3 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

jpelay commented 3 months ago

Works great! But I have to admit I had to reverse-engineer how the problem manifested.

Sorry for not being clear enough in the PR. In fairness I only realized because I used the script to fix the teacher manual in #5167 and a particular program failed to be properly formatted in every language.