search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.27k stars 282 forks source link

🪲/💻 No dropdown in single adventure mode #5641

Closed Felienne closed 2 days ago

Felienne commented 3 days ago

Describe the bug In single adventure mode (using /adventure/, such as /adventure/music) the level selector does not show:

image

This is a result of some changes, we used to have button below which did work. This is a bit annoying for workshops, can you take a look @Annelein?

Felienne commented 3 days ago

And probably we should also have a Cypres test for this (because we should have known before the changes broke this!)

Annelein commented 3 days ago

I will look at it!

Annelein commented 3 days ago

@Felienne How would a user get to /adventure ? There is indeed no Cypress test for this.

Felienne commented 3 days ago

@Felienne How would a user get to /adventure ? There is indeed no Cypress test for this.

Type it manually :) (we commonly use this in one day workshops)

Annelein commented 3 days ago

@Felienne Allright, good to know :)! Is it fine if I add tests for that page (because I don't think /adventure is covered at all) in one of the Cypress refactor PR once the Hedy page is redesigned? I will add it to this list: https://github.com/hedyorg/hedy/issues/4027#issue-1579937487

Felienne commented 3 days ago

Yes, we can totally add the tests later (if we fix the issue now)

Annelein commented 3 days ago

Yes, we can totally add the tests later (if we fix the issue now)

Great! It's ready to be reviewed