search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.33k stars 289 forks source link

🪲 fix level dropdown in custom-adventure page #5660

Closed hasan-sh closed 4 months ago

hasan-sh commented 4 months ago

fixing:

https://github.com/hedyorg/hedy/assets/20051470/fb007c32-43fc-4fc6-a04f-c8e5e2be5214

How to test?

Annelein commented 4 months ago

@hasan-sh the console error is gone, thats good! But do we want it to throw an error if there is no level selected in an adventure? Is it not fine if there is no level selected?

And the error message is: "This Hedy level is invalid." But thats not really the case because there is no level selected so how can it be invalid, "there is no level selected" should be the error message I guess?

Correct me if I'm wrong or you don't agree!

hasan-sh commented 4 months ago

@hasan-sh the console error is gone, thats good! But do we want it to throw an error if there is no level selected in an adventure? Is it not fine if there is no level selected?

And the error message is: "This Hedy level is invalid." But thats not really the case because there is no level selected so how can it be invalid, "there is no level selected" should be the error message I guess?

Correct me if I'm wrong or you don't agree!

Correct. This should be defintely handled in the front-end as well and this was the case when we used the tailwind-elements and should be present in the custom-hedy select.

Annelein commented 4 months ago

Correct. This should be defintely handled in the front-end as well and this was the case when we used the tailwind-elements and should be present in the custom-hedy select.

@hasan-sh ok, so this PR is ready for now and its handled in #5540?

mergify[bot] commented 4 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).