search

hedyorg / hedy

Hedy is a gradual programming language to teach children programming. Gradual languages use different language levels, where each level adds new concepts and syntactic complexity. At the end of the Hedy level sequence, kids master a subset of syntactically valid Python.
https://www.hedy.org
European Union Public License 1.2
1.33k stars 289 forks source link

🪲 Increase timeout for if_pressed programs #5678 #5680

Closed boryanagoncharenko closed 3 months ago

boryanagoncharenko commented 3 months ago

Fixes #5678 Increased the timeout of if_pressed programs from 10 seconds to 10 minutes. The random failures turned out to be timeouts. While cleaning up the pygame code, I think we accidentally reduced the timeout for if_pressed programs. This surfaced as random failures especially when there are multiple if_pressed executions, e.g. in a repeat command.

How to test Go to level 7 and run the following program:

repeat 3 times if x is pressed print 'x' else print 'another'

Wait for 10 seconds and then press a button. The program should not stop and there should be no errors reports in the network tab of the browser.

mergify[bot] commented 3 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] commented 3 months ago

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).