hedzr / android-file-chooser

a lightweight file/folder chooser or picker
Apache License 2.0
284 stars 62 forks source link

NewFileFilter and button color #26

Closed Guiorgy closed 6 years ago

Guiorgy commented 6 years ago

the new File Filter didn't behave as intended, also forgot to set the buttons text color (only did it to the drawables)

if (!files.remove(dirFile)) {
     files.add(dirFile);
}

remove returns true if item was removed and false if not, in other words, if a File was selected twice it has been deselected, hence we remove it from the list.

PS. just check the FileUtils, and FileChooser changes ignore everything else XD

Guiorgy commented 6 years ago

also noticed that, when you go to a new directory (or go back) it doesn't reset your scroll position.

hedzr commented 6 years ago

ok, i get it.

Guiorgy commented 6 years ago

@hedzr , so I cannot make a pull request because they "are entirely different commit histories."

anyways check my 'empty' branch hotfixes commit. what I did was:

hedzr commented 6 years ago

my fault to reformatted codes in one of commit. i'm checking and working there.