search

hedzr / android-file-chooser

a lightweight file/folder chooser or picker
Apache License 2.0
284 stars 62 forks source link

.with(this) in the sample code is obsolete #44

Closed zipswich closed 5 years ago

zipswich commented 5 years ago

It should be replaced with ChooserDialog(activity)...

hedzr commented 5 years ago

Right. It was there just because the old .with(this) is still works for compatibility.

hedzr commented 5 years ago

i'll update the codes.

zipswich commented 5 years ago

Thank you for the great tool. I am wondering if if it is worth mentioning the demo code needs to be run on the UI thread though this can be found out quickly in use.

hedzr commented 5 years ago

Well, any ui widgets, dialogs, controls should be placed to main UI thread, isn't its? If doubt exists, try RxAndroid. As your wish, a NOTE will be put up later.

hedzr commented 5 years ago

should be closed

zipswich commented 5 years ago

Thank you.