Closed Guiorgy closed 5 years ago
nice job!
i will update readme with the gif link tomorrow.
In the first commit swap lines 1021 and 1022 please :p
Those 2:
if (i == -1) break;
i = path.indexOf("/", i + 1);
need to be swapped
should i swap these two lines?
if (i == -1) break;
i = path.indexOf("/", i + 1);
PS:
_path
renamed to _pathView
?I added customizePathView(callback), renamed to _pathView
because _path
is a confusing name, and reformatted the codes, be kindly informed pls.
@hedzr
Got it. I appreciate for your consideration/understanding. About last point, i'd remembered to find another time to do that.
By the way, @hedzr, most demo apps usually have toggleable settings to let the user test more stuff. like this:
example from calcdialog.
What do you think about trying the same?
Good idea but need a bit time, I think it could be planned soon because more and more properties done.
@hedzr, I can give it a try, if you don't mind that is?
It was my pleasure!
@hedzr, looking at ChooserDiag:
public ChooserDialog titleFollowsDir(boolean followDir) {
_followDir = followDir;
return this;
}
public ChooserDialog followDir(boolean followDir) {
_followDir = followDir;
return this;
}
those 2 do the same. 1 is redundant.
yes, 2nd (followDir
) is redundant, should be removed.
an alternative solution to showing current directory in the title. a TextView at the top of the list with the current path. If whole path doesn't fit, then it gets trimmed from the left. This will not remove _folowDir, but rather give an alternative, as it doesn't require the title to be enabled. Oh, and I also updated android-maven-gradle-plugin: 2.0 -> 2.1 and kotlin-gradle-plugin: 1.3.11 -> 1.3.21.
heres a demo:![demo](https://user-images.githubusercontent.com/27736965/53578348-f1d35880-3b90-11e9-9ef4-7ed0276ca603.gif)