hedzr / android-file-chooser

a lightweight file/folder chooser or picker
Apache License 2.0
284 stars 62 forks source link

Creating a new folder window color bug in dark theme #55

Closed ytheekshana closed 5 years ago

ytheekshana commented 5 years ago

As you said here, I am using a custom row layout to give a dark mode. But how to change the alert textbox and its text color when creating a new folder. Check the screenshot to get an idea about what I am saying. I checked the demo app in the 1.2.X branch. The same thing happens in it too when in night mode.

see the image file-chooser

Guiorgy commented 5 years ago

you cant right now as it is created programatically. the best solution for everyone is probably to create a custom Theme for the library.

Guiorgy commented 5 years ago

@ytheekshana, by the way, what theme are you using for the dialog?

Guiorgy commented 5 years ago

@ytheekshana, some stylables where added to the library. Could you test them and see if that helps you?

ytheekshana commented 5 years ago

@ytheekshana, some stylables where added to the library. Could you test them and see if that helps you?

Yap. Now it looks perfect. Can you release the 1.1.17 to public now.

Guiorgy commented 5 years ago

@ytheekshana, we are still editing a few things here and there. We are hoping to release it on this weekend though.

ytheekshana commented 5 years ago

1 2

Why is the window width in the dark mode is small? How can I get the same width as the light version?

Guiorgy commented 5 years ago

@ytheekshana, what android is that? I am getting the same width on an api 28 emulator. If you want to change something like width, it should be in the AlertDialogs theme. edit. try:

<item name="windowFixedWidthMajor">70%</item>
<item name="windowFixedWidthMinor">70%</item>
ytheekshana commented 5 years ago

Perfect..... Here's a suggestion, Please make it possible to change the accent color programmatically. Also, make it possible to toggle the dark theme programmatically.

Guiorgy commented 5 years ago

@ytheekshana, change accent color programmatically? why? can't you do it through the styles? do you mean changing colors and theme while the dialog is showing?

also, the 'dark theme' is not part of the library, but just an example in the demo app. At least not as of right now anyways.