search

hedzr / android-file-chooser

a lightweight file/folder chooser or picker
Apache License 2.0
284 stars 62 forks source link

FileChooser style #56

Closed Guiorgy closed 5 years ago

Guiorgy commented 5 years ago

Added stylables and attributes to allow view modifying. PR for issue #55 Also, added a new checkbox to the demo app Use dark theme, and an example FileChooserStyle.Dark style.

2019_03_18_13_40_43

Guiorgy commented 5 years ago

@hedzr, I have only tested the example dark theme on api 26 (real phone), so might want to test it first. Also, if you have any sugestions, or thoughts please let me know.

Guiorgy commented 5 years ago

just tested on kitkat emulator. need more tweeking

hedzr commented 5 years ago

I'm online... I'm so thankful for your work.

Guiorgy commented 5 years ago

sure, but I am having trouble on api < 21 :P need some more time

Guiorgy commented 5 years ago

so I tryed your master branch (literaly downloaded zip and opened in AS), and this is what I get in a kitkat emulator: untitled it doesn't resize properly...

Guiorgy commented 5 years ago

@hedzr, so I just tried my devel branch (with the style changes) and it works fine on kitkat. Seems like you introduced a bug in a recent commit?

Guiorgy commented 5 years ago

nevermind, I think I found it. The problem occurs when displayPath is enabled 😓 as for the styles, I think they work fine.

hedzr commented 5 years ago

OK. I'd pulled the new patch.

hedzr commented 5 years ago

I have to speak the truth that's really big chaos!! For the colors in dark theme, I don't known whether it's worth to do. So you did an amazing job.

We could publish and trace it. I'll release as a new one later (in two days).

Guiorgy commented 5 years ago
  1. Honestly I have only used styles a few times myself, so there probably is space for improvement.
  2. The dark theme example is as I said, just an example. I can't say that I have a good eye for good design, so I just did whatever as a proof of concept. You can try and make it look better by all means thoug :)
  3. I'll send another PR shortly with the displayPath and alertDialog buttons order bug fixes shortly
hedzr commented 5 years ago

@Guiorgy, Would you like be a collaborator of this project?

Guiorgy commented 5 years ago

@hedzr, I would have to warn you, I am known for messing up things...

hedzr commented 5 years ago

That's a little thing. never mind the styles and the chaos i said. we always comply with it if we had to use android styles. so i'm just talking.