Closed Guiorgy closed 5 years ago
@hedzr, I have only tested the example dark theme on api 26 (real phone), so might want to test it first. Also, if you have any sugestions, or thoughts please let me know.
just tested on kitkat emulator. need more tweeking
I'm online... I'm so thankful for your work.
sure, but I am having trouble on api < 21 :P need some more time
so I tryed your master branch (literaly downloaded zip and opened in AS), and this is what I get in a kitkat emulator:
it doesn't resize properly...
@hedzr, so I just tried my devel branch (with the style changes) and it works fine on kitkat. Seems like you introduced a bug in a recent commit?
nevermind, I think I found it. The problem occurs when displayPath is enabled 😓 as for the styles, I think they work fine.
OK. I'd pulled the new patch.
I have to speak the truth that's really big chaos!! For the colors in dark theme, I don't known whether it's worth to do. So you did an amazing job.
We could publish and trace it. I'll release as a new one later (in two days).
@Guiorgy, Would you like be a collaborator of this project?
@hedzr, I would have to warn you, I am known for messing up things...
That's a little thing. never mind the styles and the chaos i said. we always comply with it if we had to use android styles. so i'm just talking.
Added stylables and attributes to allow view modifying. PR for issue #55 Also, added a new checkbox to the demo app Use dark theme, and an example FileChooserStyle.Dark style.