search

hedzr / android-file-chooser

a lightweight file/folder chooser or picker
Apache License 2.0
284 stars 62 forks source link

The cancel and ok buttons display on the bottom-left corner of the dialog #62

Closed lxfly2000 closed 5 years ago

lxfly2000 commented 5 years ago

I'm using 1.1.17 version and codes from README.md choosing a folder, the choose and cancel buttons are not displayed on the bottom-right corner as I expect while 1.1.16 version works fine.

Guiorgy commented 5 years ago

That was a side effect of an attemt to remove an inconsistency of the buttons order/gravity dependent on the theme. For the next release I have set the order to: neutral (options) left, negative (cancel) center, positive (ok) right. Screenshot_1555310787 Will this be alright, or would you suggest differently?

lxfly2000 commented 5 years ago

That's ok. In my app the menu button “⋮” is not needed so just like the normal AlertDialog, place the cancel and choose buttons on the right if I don't call enableOptions(true).

Guiorgy commented 5 years ago

Screenshot_1555327780 is this what you wanted?

lxfly2000 commented 5 years ago

Yes

Guiorgy commented 5 years ago

got it. will be changed in the next release. you can test the changes with this until release: implementation 'com.github.hedzr:android-file-chooser:experimental~dpad-SNAPSHOT' if you find any more problems, or have any suggestions, please don't hesitate

Guiorgy commented 5 years ago

1.1.19 out, please confirm that the problem has been solved.