Closed Buggaboo closed 5 years ago
Nice! I do appreciate the work.
x1.2.0 had been held because these reasons:
The second pt should be noted here. Therefore, if you completed the works from x1.2.0, it could be not a good start. I'm sure that's my bad. I should have advanced it (x1.2.0) with master/devel branch, that ought to be a better start.
So @Buggaboo, would you like transform to androidx as new-x1.2.0
starting with our newest devel
branch? If so, I'll make the branch for your new PR, and, the x1.2.0
can be archived from then on.
Sorry, I don't think I understand you completely, you're asking if I want my PR branch to replace x1.2.0?
I can also apply the same changes to the master branch if you like. I require a new release with the androidx and androidx.appcompat.app.AlertDialog changes.
well my ado.
shortly, our x1.2.0
is too older than devel. it's not worthy to merge your work. so we can make a new branch named as new-x1.2.0
based on devel, could you please migrate your changes on this new one?
Ah, I understand, yes I will send a new PR based on this new new-x1.2.0
branch.
💃
There is it: new-x1.2.0
.
seems we can close this PR as there's #67 instead. Also, @hedzr, how about we remove the old 1.2.0 branch to prevent future confusion? (if theres anything there, we can keep it localy for now)
Changes