heecheon92 / Android-Project

Local Event App
0 stars 0 forks source link

Unnecessary Scroll View #11

Open MoonWolf125 opened 5 years ago

MoonWolf125 commented 5 years ago

It's generally good use to use a Scroll View for screens that require user input. However, this screen is not optimized for a Scroll View as the form is not covered by the keyboard on most phones. The Scroll View should be the parent with one LinearLayout holding the login form as a toolbar was not required by the documentation and the Manifest will need to be adjusted to the corresponding change.

You're more than welcome to follow up with me on this issue as it's a bit in depth!

https://github.com/heecheon92/Android-Project/blob/a05d23c117f810ca2ff297a08d27d7d918636451/FargoEventProject/app/src/main/res/layout/activity_event.xml#L52-L55