search

heecheon92 / Android-Project

Local Event App
0 stars 0 forks source link

Event List Styling #7

Open MoonWolf125 opened 5 years ago

MoonWolf125 commented 5 years ago

  1. Overflow Menu is the wrong color, it is black when it should be white

    • White has a stronger contrast against the darker blue thus increasing notice

  2. Check token Menu option is unnecessary and could potentially be dangerous

    • Should never allow a user to see a token that is sent from a server
    • This can be useful for testing but should be removed in the end or replaced with the Log functions
    • Not a part of the challenge document: The overflow icon should display one option “Log Out” which just clears the user’s Login information

  3. Preview pictures are large

    • Add padding and follow the design to ease eye strain on the user

  4. Events show location but not the date or time as shown in the design

    • Follow the design

  5. No Padding

    • Put some padding between the items to ease eye strain on the user

  6. Remove unnecessary Snackbars that show the events title as it distracts the user by showing a popup https://github.com/heecheon92/Android-Project/blob/a05d23c117f810ca2ff297a08d27d7d918636451/FargoEventProject/app/src/main/java/com/example/heecheonpark/parkfinalproject/CustomListAdapter.java#L141

  7. Incorrect Text sizing and colors:

    • The title text is more of a gray than a solid black, center instead of left justified, and larger than the design in the document
    • Make sure to follow the design to ease the work required by the user to synthesize the displayed information

  8. SearchView doesn't work

Overall the general issue is that the design isn't being followed when it should be. The SearchView is a major culprit here as well. While it's an attempt, items that cause an app to crash should not be shown or implemented in an application that is deployed, demoed, or showed. Either complete the implementation, or remove it.