heeeyi / pe

0 stars 0 forks source link

Multiple description allowed, but only the last one is accepted #4

Open heeeyi opened 1 year ago

heeeyi commented 1 year ago

image.png

Currently, this app allows multiple "d/" prefix, but will only take the last one. It is not said in UG or DG anywhere that this behaviour is expected. If I am the user, I may want to add multiple descriptions, but found only the last one appears.

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear over what is "one command flag" for find command

find r/aaa r/aaa This would work, but some users may think that 2 command flags are present and hence are expecting an error

I rate this a documentation bug as it should be changed to "one type of command flag". I rate it severity.low as it only affects users in rare cases. It is not severity.verylow as it is more than cosmetic error


[original: nus-cs2103-AY2223S2/pe-interim#3908] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Yes, we forgot to mention in the UG that we will take the last entry if there are many entries of the same command flag.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is not the same as the other bug. The other is only referring to the "one command flag" issue regarding "find" command, which is recorded in UG. However, my issue is referring to the special behaviour of d/, that is implemented but not recorded in UG and DG. Under this behaviour, if the command itself does not accept multiple value of the field following d/, then when you specify multiple copies of d/, only the value following the last one will be taken. I feel this very important to be documented.


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I feel this issue is not limited to "very rare situations". For users who are accustomed to type quickly, when finding that they mistyped d/ field, they may prefer specifying the field again by having another d/ field, comapred to go back and deleting the previous content. However, this could only be done if the group made it clear in UG and DG that specifying multiple prefixes is allowed, and the last one will be taken.y Furthermore, given this is description, some users may expect "multiple descriptions allowed" by typing multiple d/ content in command. If it is not made clear in UG that only the last one is accepted, they may feel surprised to see the behaviour deviate from expectations.