heeeyi / pe

0 stars 0 forks source link

Inappropriate error message for description restriction #7

Open heeeyi opened 1 year ago

heeeyi commented 1 year ago

image.png

Currently, when I type this as descriptions, it said the error is "description must be a sentence". However, this does look like a valid sentence for me. Should be more accurate, like "Special characters not allowed in description"

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add Command: Instruction does not allow for dashes

I believe that titles should be allowed to accept hyphen-dashes, espcially since there are words that exist in the dictionary that have dashes.

Not frequent to have such words but may still confuse the user especially since the error message claims that a word/sentence was not given for the title when orange-juice is considered a word

image.png


[original: nus-cs2103-AY2223S2/pe-interim#2765] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is a feature flaw as we only take in alphanumeric and space when parsing user inputs for descriptions/titles/etc.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I do not feel this is a duplicate with another issue. The other issue is emphasising on the behaviour the software is "supposed" to have, i.e. it SHOULD accept special characters; On the other hand, my issue is emphasising that GIVEN it does not accept special characters, it should provide more accurate error message, to tell users what is exactly the issue with their input titles.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]