search

heeeyi / pe

0 stars 0 forks source link

Find by title list more items than it is supposed to do #8

Open heeeyi opened 1 year ago

heeeyi commented 1 year ago

image.png

I added multiple "Banana shake" with different name, one of them "Banana shake 00". So I want to just find this shake. However, when I type "find t/shake 00", all the items with "shake" in their name appears in the search result. This is not expected.

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear over how find command works

Consider an entry with title "Corndogs for the win" In the user guide, it is unclear whether find is exact match, or matches one word, or just a substring.

I rate this as severity.medium as it affects most users who will be confused about how the find command works - only when they test it out then they realise it is substring (I think?). This would essentially affect the usage of the entire find command

[original: nus-cs2103-AY2223S2/pe-interim#2778] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I feel this is a different bug. The other is just about the general necessity to make "find" command clearer, while my issue is about the specific behaviour of "find" word-matching mechanism. Actually I know that the implementaiton is probably matching a stream of word, if any matches then return the record. This special behaviour should be made clear in UG and DG. This is because it could be confused with another "entire string matching" mechanism, resulting in different user expectations. For example, if there are records "cake", "cakes", "cake base", by entering "cake b", stream-word-matching gives "cake" and "cake base", while entire-string-matching only gives "cake base". This is totally different expectations.

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]