heejet / pe

0 stars 0 forks source link

Grammatical error in prev error message #6

Open heejet opened 1 year ago

heejet commented 1 year ago

Slight grammatical error in the error message. Perhaps you could say something like "There are no previously generated questions" instead.

image.png

nus-se-script commented 1 year ago

Team's Response

Thank you for the report!

Unfortunately, after much deliberation we have decided to reject this bug.

Your report solely mentioned that there is grammatical error without elaborating on which part is confusing. As a result, the report is ambiguous and we do not know what exactly the confusion is. So, we decided to thoroughly examine this sentence and we eventually could not find any grammatical issue with this sentence.

The team did their own research and do not think that the sentence has any issue. This is our analysis:

"A set of questions" is a collection of questions which is singular. Here, we emphasize that it is a set. Hence, "has" should be used.

image.png

Moreover, "a set of questions" is the object that experiences users' action, hence, a passive voice should be used here. The past participate form of "get" is "gotten". It is about the set of question at sometime up to now, present perfect passive tense should be used (i.e. "has not been gotten"). Here is the link for reference: https://www.grammarbank.com/present-perfect-passive.html

While there are many other ways to deliver the same meaning, there is nothing wrong to use the current sentence.

Lastly, based on context and the self-explanatory nature of the command nameprev(ious), users would be able to interpret the sentence correctly and understand that the common failed as a set of questions has not been retrieved yet based on the error message.

As such we hope you understand why we are rejecting this bug report.

We hope this clarifies, thank you!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I apologise for not making the grammatical error clear. My issue is not with "a set of questions" but with "has not been gotten". The link you sent is informative on the use of present perfect tense but unfortunately does not cover the use of the word "gotten" therefore here is a more informative link instead. In the use of perfect tense, the word "been" is usually omitted when using the word "gotten".

image.png

Therefore, the use of the phrase "been gotten" is grammatically incorrect which is why I suggested a change in error message. I fully understand the intent behind the error message but unfortunately the delivery needs improvement. Therefore, I marked this as `VeryLow" because this is indeed a cosmetic issue.