search

heetch / Android-country-picker

[DEPRECATED] This library is not maintained anymore. No more development will be done.
Apache License 2.0
31 stars 15 forks source link

Added round icons, ability to get country name #3

Closed xsorifc28 closed 8 years ago

xsorifc28 commented 9 years ago

Updated imports as well.

See commit for details.

EKami commented 9 years ago

Thank you for your contribution but could you get rid of all the .idea/* files as well as the Android-country-picker.iml? Btw, do you think programmatically creating a rounded image from the existing res is a better choice? Adding new res will double the lib size and is error prone as we are not sure if all the new rounded image match the old ones in terms of design/right flag (I didn't check all the flags).

xsorifc28 commented 9 years ago

Sure, I can remove the said directory and files.

I wasn't sure if adding the res was a good idea or not.. for my purpose, I am adding/removing hundreds of flags from a map so I thought having a static res would be faster and easier on battery ?

I'm open to discussion and suggestions, can't say I'm an expert developer :/

EKami commented 9 years ago

Excuse me for my mistake but by "getting rid of" I meant "let these files untouched". Battery consuming can in fact be improved by using static res instead of programmatically creating them. But the gain in battery consumption is very small and the drawback here is that we will double the size of the library. In the end, when someone will use this he will want to have either round res or the normal ones, he usually won't use both but he will have to integrate a 2x larger library than it initially was.