search

heetch / Android-country-picker

[DEPRECATED] This library is not maintained anymore. No more development will be done.
Apache License 2.0
31 stars 15 forks source link

Transparent space in png's #4

Open xsorifc28 opened 8 years ago

xsorifc28 commented 8 years ago

Is there a reason as to why there is a transparent gap in the png's ?

Just wondering.

EKami commented 8 years ago

There is none but didn't see this as a problem at the time the lib was made. Do you need pngs with no gaps?

xsorifc28 commented 8 years ago

It helps to predict the size better and adjust padding/margins. It is hard to take into account the transparency when using the icons outside of the country picker (I access the flag bitmaps elsewhere in my project).

EKami commented 8 years ago

Alright, having no gap in the pngs could indeed be helpful. I don't have the time for the moment to make the changes. Could you open up a PR with the removed gaps from the icons? I would be greatly appreciated.

xsorifc28 commented 8 years ago

Do you have the icons as vectors or a script already? How did you generate the original ones?

EKami commented 8 years ago

The flags come from this repository