heetch / felice

Felice is a nascent, opinionated Kafka library for Go, in Go
MIT License
20 stars 1 forks source link

Lack of integration tests #48

Closed asdine closed 5 years ago

asdine commented 5 years ago

Currently, we are using mocks to test Felice code which means that unless we manually create a main to test the code every time, there's no way to make sure we didn't break anything.

I propose to create a few integration tests protected by a flag, a build tag or whatever that would connect to an actual Kafka instance and test the production and the consumption. The goal of these tests is solely to test the global behavior. These tests would be run on Drone only

cc @rogpeppe

tealeg commented 5 years ago

Fixed by #52