search

heetch / felice

Felice is a nascent, opinionated Kafka library for Go, in Go
MIT License
20 stars 1 forks source link

update to go1.20 and update dependencies #68

Closed adrianmester closed 1 year ago

adrianmester commented 1 year ago

Just a bit of gardening, updated to go 1.20, and updated dependencies

adrianmester commented 1 year ago

For Sarama it can be worth checking for any changes that might affect us. With galaxy-go using 1.30.1, we should be able to assume that someone from Boost at least checked until that version, and some services already explicitly use newer versions and hopefully someone checked those as well, but that's not certain.

For example v1.33 has this breaking change.

Did you check if felice does that == error check somewhere?

Approving already in case of yes.

Thanks for catching that, I didn't consider this.

Since the plan is to merge this into galaxy-go, I'll just use the versions that are currently used there