search

heetch / sqalx

Nested transactions for sqlx
MIT License
159 stars 25 forks source link

Nice work - exactly what I was looking for but... #22

Open rmsj opened 2 years ago

rmsj commented 2 years ago

Have you considered this as a PR for SQLx?

skateinmars commented 2 years ago

Hey @rmsj (and sorry for the delay in the answer)

Originally we created a separate package because this feature is almost only useful when using savepoints (so, with PostgreSQL only) But maybe there is indeed a potential interest in backporting some or all of the changes to sqlx! Please feel free to open a feature request issue on their repo

carpii commented 1 year ago

Do we know if this was ever suggested as a merge to sqlx?

savepoints are not postgres specific, but have been part of the SQL standard for many years now (so should be widely supported).

skateinmars commented 1 year ago

Hey @carpii thanks for your feedback We did plan to try to get this merged to sqlx but unfortunately the upstream repository seems to be unmaintained (no commits/merge since April 2022)

Also please note, we are in the process of marking this repo as maintenance only and will stop adding any features.

carpii commented 1 year ago

Ok, I understand. Thanks for the reply 👍