search

heeyeonwiz / pbscc-proxy

Automatically exported from code.google.com/p/pbscc-proxy
0 stars 0 forks source link

The field for comments on commit is too small #10

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What is the expected output? What do you see instead?
The field for comments on commit only accepts 65 characters. That
is too small.
Ideally it should be unlimited with more than one line for editing.
Thank you,
-Yuri

What version of the product are you using?
2.00.50

Original issue reported on code.google.com by yuri.de...@gmail.com on 10 Aug 2010 at 9:27

GoogleCodeExporter commented 8 years ago 
FWIW, here we managed to patch the dialog resource to enlarge a bit the comment 
area, and we changed the drop-down by a list for the recent comments.

Consider this a suggestion for the modification of the dialog. :o)

Original comment by sebastie...@gmail.com on 12 Aug 2010 at 11:27

Attachments:

GoogleCodeExporter commented 8 years ago 
great, and where is the patch? :)

Original comment by daggett....@gmail.com on 12 Aug 2010 at 4:41

GoogleCodeExporter commented 8 years ago 
It was manually patched with the resource editor ResHacker. I have only a 
patched dll. 
If I extract the .rc for the dialog 1001, I get the following (the remark about 
not using double quotes is related to the issue #1 you recently fixed ;)

1001 DIALOG 37, 70, 404, 226
STYLE 0x10C808C0
CAPTION "PBSCC Proxy"
FONT 8, "MS Shell Dlg"
LANGUAGE 9, 1
BEGIN
  CONTROL "Description", -1, BUTTON, 0x50000007, 7, 7, 390, 188
  CONTROL "", 1002, COMBOBOX, 0x50330040, 50, 18, 338, 123
  CONTROL "", 1003, EDIT, 0x50B008C4, 48, 144, 342, 42
  CONTROL "OK", 1, BUTTON, 0x50030001, 158, 203, 50, 14
  CONTROL "Cancel", 2, BUTTON, 0x50030000, 212, 203, 50, 14
  CONTROL "Message :                                     DO NOT USE DOUBLE QUOTE !!! ( \" )", -1, STATIC, 0x50000000, 13, 19, 35, 118
  CONTROL "Path : ", -1, STATIC, 0x50000000, 11, 144, 35, 10
END

Original comment by sebastie...@gmail.com on 12 Aug 2010 at 9:12

GoogleCodeExporter commented 8 years ago 
Here is the patched dll (it is a previous 1.xx release)

Original comment by sebastie...@gmail.com on 12 Aug 2010 at 9:23

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi, here is a patch for to enlarged comment field up to 1000 chars.
I have used the last revision available...

Original comment by famille....@gmail.com on 26 Aug 2010 at 1:47

Attachments:

GoogleCodeExporter commented 8 years ago 
new version pbsccsetup_2.00.57.zip published
it has larger commit message window.

waiting for feedback.

Original comment by daggett....@gmail.com on 1 Sep 2010 at 7:32

Attachments:

GoogleCodeExporter commented 8 years ago 
i don't like unlimited things, so i put limit 2000 chars.

Original comment by daggett....@gmail.com on 3 Sep 2010 at 6:39

GoogleCodeExporter commented 8 years ago 
That works, thank you!

Original comment by yuri.de...@gmail.com on 13 Sep 2010 at 4:24

GoogleCodeExporter commented 8 years ago

Original comment by daggett....@gmail.com on 13 Sep 2010 at 4:53

GoogleCodeExporter commented 8 years ago 
This refactored dialog is great! Thanks :o)

Original comment by sebastie...@gmail.com on 14 Sep 2010 at 10:39