search

hegocre / NextcloudPasswords

Secure app for viewing passwords for the Nextcloud Passwords app. Supports end-to-end encryption.
GNU General Public License v3.0
50 stars 0 forks source link

Possible Bug: PIN Pad does not reflow in Landscape Orientation #76

Closed Saijin-Naib closed 7 months ago

Saijin-Naib commented 8 months ago

When inputting the PIN, one must be in Portrait otherwise none but the top three number buttons are accessible.

Ideally, this would reflow to be usable no matter the orientation.

Screenshot_20240102-181430

SteveCaruso commented 8 months ago

Similar problem on small screens.

I'm running Nextcloud Passwords on a Lemfo APPLLP 4 Pro which is a round-panel 400x400 screen, and only the first row of pin buttons are visible.

hegocre commented 7 months ago

Hello,

I've created a pull request with a fix for this. It would be great if you could both test the new version and see if it is fixed, specially you @SteveCaruso with the round panel, which I don't have, so I cannot test.

Thank you!

SteveCaruso commented 7 months ago

Once it hits F-Droid I'll report back. :-)

hegocre commented 7 months ago

Would it be possible for you to test the latest APK from the Actions tab corresponding to this PR? That would help publish an APK which we make sure it fixes the problem.

The app in the actions tab is the latest version compiled from the source code of the last commit, which means the APK file comes from the code published on this repo.

You can download it from the artifacts section on this page (https://github.com/hegocre/NextcloudPasswords/actions/runs/7777365005).

Thank you very much!

SteveCaruso commented 7 months ago

I had to finagle it (the screen size and watch interface makes it tricky to navigate GitHub) but I managed to get it running and I can confirm it works perfectly now. :-)

passcode works

Thank you!

Saijin-Naib commented 7 months ago

Reflows right-aligned for me, but totally usable!

Thanks!

hegocre commented 7 months ago

@SteveCaruso That's nice to hear, thank you! @Saijin-Naib what do you mean? On lanscape orientations, it should appear in two columns, one for the text + dot indicators and one for the keypad, and all should be center-aligned within its column. Is that how it appears to you?

Thank you both!

Saijin-Naib commented 7 months ago

Ah, yes. The keypad is to the right half of the screen, but centered on itself, the way I had my phone in landscape.

Sounds like working as it should :)