search

heidelbergcement / hcrystalball

A library that unifies the API for most commonly used libraries and modeling techniques for time-series forecasting in the Python ecosystem.
https://hcrystalball.readthedocs.io/
MIT License
152 stars 19 forks source link

Improve and test optional imports #34

Closed MichalChromcak closed 4 years ago

MichalChromcak commented 4 years ago

AC - tested function that does optional imports is in place

MichalChromcak commented 4 years ago

@pavelkrizek have a look, please

codecov-commenter commented 4 years ago

Codecov Report

Merging #34 into master will increase coverage by 1.56%. The diff coverage is 98.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   91.65%   93.21%   +1.56%     
==========================================
  Files          55       55              
  Lines        2456     2448       -8     
==========================================
+ Hits         2251     2282      +31     
+ Misses        205      166      -39
Impacted Files Coverage Δ
tests/integration/test_data_unchanged.py 97.61% <90.90%> (+17.26%) :arrow_up:
...rc/hcrystalball/model_selection/_model_selector.py 95.40% <100.00%> (ø)
src/hcrystalball/utils.py 84.12% <100.00%> (+1.07%) :arrow_up:
src/hcrystalball/wrappers/__init__.py 100.00% <100.00%> (+52.83%) :arrow_up:
tests/unit/model_selection/test_model_selector.py 100.00% <100.00%> (ø)
tests/unit/test_utils.py 95.14% <100.00%> (+1.72%) :arrow_up:
...talball/feature_extraction/_holiday_transformer.py 97.22% <0.00%> (+2.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fac53c0...0fe31ce. Read the comment docs.