Closed MichalChromcak closed 3 years ago
Merging #63 (c14fcde) into master (33fcf2e) will increase coverage by
0.01%
. The diff coverage is97.32%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 93.61% 93.63% +0.01%
==========================================
Files 56 56
Lines 2633 2735 +102
==========================================
+ Hits 2465 2561 +96
- Misses 168 174 +6
Impacted Files | Coverage Δ | |
---|---|---|
setup.py | 0.00% <0.00%> (ø) |
|
src/hcrystalball/utils.py | 83.63% <83.33%> (-0.54%) |
:arrow_down: |
src/hcrystalball/__init__.py | 83.33% <100.00%> (ø) |
|
src/hcrystalball/compose/_ts_column_transformer.py | 88.46% <100.00%> (+0.22%) |
:arrow_up: |
src/hcrystalball/ensemble/_simple_ensemble.py | 100.00% <100.00%> (ø) |
|
src/hcrystalball/ensemble/_stacking_ensemble.py | 96.34% <100.00%> (ø) |
|
...talball/feature_extraction/_holiday_transformer.py | 96.36% <100.00%> (+0.06%) |
:arrow_up: |
...alball/feature_extraction/_seasonal_transformer.py | 95.58% <100.00%> (+0.06%) |
:arrow_up: |
src/hcrystalball/metrics/__init__.py | 100.00% <100.00%> (ø) |
|
src/hcrystalball/metrics/_scorer.py | 95.00% <100.00%> (+0.08%) |
:arrow_up: |
... and 39 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 25f186d...c14fcde. Read the comment docs.
@MichalChromcak Thanks. Is there any example of the issue this supposed to solve? I agree that this is difficult to test, but seeing the problem could help to decide whether this feature solves it or not. I'm also not sure why just some wrappers have the hcb_verbose
option and others not? Couldn't see it for Sarimax and TBATS...I also think that the output is usually not so big problem when running one wrapper, but rather running a bigger grid with select_model
so in order to solve any problem with logging it would be helpful to propagate the flag hcb_verbose
to higher-level function i.e. create_gridsearch
.
This PR aims to help setup/reduce logging mainly from the 3rd party libraries to make logs more sensible based on the expected usage.
PR
03_logging.ipynb
to showcase the logging best practices, where one could try different setup which might fit his/her needs.hcb_verbose
flag usage)isort
,json checker
andjson prettifer
topre-commit
hookspre-commit
hooks versionspre-commit
on all files (-> big diff)