heidelbergcement / hcrystalball

A library that unifies the API for most commonly used libraries and modeling techniques for time-series forecasting in the Python ecosystem.
https://hcrystalball.readthedocs.io/
MIT License
152 stars 19 forks source link

New versions of 3rd party packages, support for python 3.8 #64

Closed MichalChromcak closed 3 years ago

MichalChromcak commented 3 years ago

This PR covers

prophet=1.0.1
pmdarima=1.8.1
scikit-learn=0.24
tbats=1.1.0
workalendar=15.3
pandas=1.2
numpy=1.20
codecov-commenter commented 3 years ago

Codecov Report

Merging #64 (a46c18d) into master (33fcf2e) will increase coverage by 0.08%. The diff coverage is 100.00%.

:exclamation: Current head a46c18d differs from pull request most recent head 25fad16. Consider uploading reports for the commit 25fad16 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   93.61%   93.70%   +0.08%     
==========================================
  Files          56       56              
  Lines        2633     2670      +37     
==========================================
+ Hits         2465     2502      +37     
  Misses        168      168              
Impacted Files Coverage Δ
src/hcrystalball/model_selection/_configuration.py 96.42% <ø> (ø)
...rc/hcrystalball/model_selection/_model_selector.py 95.50% <ø> (ø)
tests/unit/test_utils.py 95.41% <ø> (ø)
...alball/feature_extraction/_seasonal_transformer.py 95.52% <100.00%> (ø)
src/hcrystalball/model_selection/__init__.py 100.00% <100.00%> (ø)
...l/model_selection/_large_scale_cross_validation.py 91.57% <100.00%> (+0.99%) :arrow_up:
...stalball/model_selection/_model_selector_result.py 82.85% <100.00%> (+0.24%) :arrow_up:
src/hcrystalball/wrappers/_prophet.py 94.93% <100.00%> (ø)
src/hcrystalball/wrappers/_sarimax.py 92.30% <100.00%> (ø)
tests/conftest.py 86.16% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25f186d...25fad16. Read the comment docs.

MichalChromcak commented 3 years ago

The CI is failing on Windows for python 3.6 - the conda is unable to resolve dependencies. Removing support for python 3.6 solves the issue and I'd be up for it. What do you think @pavelkrizek ?

pavelkrizek commented 3 years ago

The CI is failing on Windows for python 3.6 - the conda is unable to resolve dependencies. Removing support for python 3.6 solves the issue and I'd be up for it. What do you think @pavelkrizek ?

Thanks, for updating the dependencies. I agree, let's drop support for 3.6.