Open MichalChromcak opened 2 years ago
@pavelkrizek FYI
Merging #70 (24bbfb3) into master (11166bd) will decrease coverage by
0.06%
. The diff coverage is90.24%
.
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 93.79% 93.73% -0.07%
==========================================
Files 56 56
Lines 2853 2888 +35
==========================================
+ Hits 2676 2707 +31
- Misses 177 181 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/hcrystalball/wrappers/_sklearn.py | 94.80% <ø> (ø) |
|
src/hcrystalball/metrics/_scorer.py | 90.66% <78.94%> (-4.50%) |
:arrow_down: |
tests/unit/metrics/test_scorer.py | 93.93% <100.00%> (+1.73%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eeb32b9...24bbfb3. Read the comment docs.
@MichalChromcak Thanks for catching and fixing the bug! Everything is good from my side, just the function results_to_cv_data
is quite complex and it's hard to see what exactly is happening there, so a more descriptive docstring would be helpful.
In certain cases, the current behaviour of the
scorer
stores thecv_data
wrongly (see the split numbers). Further plotting and evaluation functionality is partially affected by that.This MR aims to fix this.
Example: