heidmic / suprb

GNU General Public License v3.0
6 stars 3 forks source link

Should we use rule.match.volume_ rather than rule.volume_? #116

Open heidmic opened 2 years ago

heidmic commented 2 years ago

As it stands, rule.volume just passes through the results from rule.match.volume. This can increase readability by decreasing line lengths. However, it might obscure some issue in the future.

This issue is primarily meant as an opportunity to discuss this based on

Do we need this or can we use self.match.volume_ wherever we usually would use volume_?

_Originally posted by @RomanSraj in https://github.com/heidmic/suprb/pull/113#discussion_r932181126_

If we determine that we indeed want to change this, this issue also bundles the implementory aspects