search

heidmic / suprb

GNU General Public License v3.0
6 stars 3 forks source link

Add aditional representations #120

Closed hubanton closed 1 year ago

hubanton commented 2 years ago

Added UBR, CSR and MPR. Matching functions as well as Initialization and Mutation were adjusted.

hubanton commented 2 years ago

Also added the adaptive heuristic used in my thesis. For CSR only the mutation rate affecting the Spread is altered, whereas for MPR both rates are altered, hence the additional if-statements.

heidmic commented 2 years ago

Did not yet get around for a full review but can you please split the PRs for the representations and adaptive mutation? While I get why you added it here (as both are part of your thesis), from a purely SupRB point of view the two have little in common (besides a dependency). Easiest way would be to remove the commit from this branch and add it to a new one (basing on this)

heidmic commented 1 year ago

LGTM

2 points for @heidmic:

* We should consider writing unit tests for the different functions

* Will type errors effect the optuna tuner and do we need to change something there so we don't run into these kind of cases?

Valid points. Can you please check Optunas behaviour? Unit tests should be a separate issue, I think? @hubanton would you be available to provide those?