heidmic / suprb

GNU General Public License v3.0
6 stars 3 forks source link

Variance-based acceptance only works correctly for rules that match all inputs #159

Open heidmic opened 2 months ago

heidmic commented 2 months ago

https://github.com/heidmic/suprb/blob/2af04212216ffd6a01160167f50ee01e62b2b36c/suprb/optimizer/rule/acceptance.py#L27

@dpaetzel says: if mean(local_y) == 0, then this is a 1/beta–weighted variance, however, this assumption is wrong for non-general rules