heigvd-teaching-tools / online-test-platform

EVAL is an educational platform for managing training exercises and exams, featuring specialized question types for software engineering education and training.
Apache License 2.0
5 stars 0 forks source link

Evaluation Access List edge case #236

Open Ovich opened 4 months ago

Ovich commented 4 months ago

Reproduction:

Effects:

Fix:

DRAFT PHASE:

We must decide, or let the user decide, what to do with students who have already joined before the restriction was activated. The professor could choose to add them to the access list or to remove them from the evaluation (so they don’t appear in the registered students). This involves deleting all the pre-generated empty answers for the student. Alternatively, we could choose one of these actions by design. Adding them to the access list would be easier to implement and would make sense for most cases.

What do we do when the already registered student is being removed from the access list input field? In this case, it makes more sense to remove the student from the evaluation, or to prevent the removal of the registered student from the access list. A confirmation / alert dialog would be necessary. Note that if the student uses the link later (DRAFT or IN PROGRESS), they will end up in the denied student list and can be allowed to enter using "add to access list".

Another option: Make the restriction toggle button read-only if someone has already registered for the evaluation. Professors usually join their own evaluation in the draft phase. Implementing this could lead to issues and the necessity to recreate the evaluation if they wish to activate the restricted access later on.

Ovich commented 4 months ago

@bchapuis what do you think?