heikkilevanto
commented
1 year ago Getting the coordinates is just a simple javascript operation. Needs to be async, because the browser may ask the user to allow the coordinates to be used. Still, we can store current coordinates in the callback function.
The next problem is that we probably need to collect a few sets of coordinates for each location, to average out errors. That can best be done by storing the coordinates every time a beer is filed. We should actually call the coordinate-getting function on the save button, so as to get the latest coordinates - the page may have been up while I walk to another bar. If we have permission, we get better coordinates. If not, then not.
We should probably also disable the auto-filling of a default location in the form. If the user enters a location, we must trust that. If not, we can try to guess by coordinates, and if that fails, default to the latest location. We still need an algorithm to guess if are at a known beer location, or somewhere unknown.
When editing a beer entry, we should of course keep the location data as it is, or allow the user to edit/remove it. Editing of records may well happen on a different location, like after coming home.
One last problem is the format of the data file. We can add coordinates to the location field, as in "Ølbaren [lat/long]", and filter the [] away before displaying or filtering. When reading the file, we can collect all the coordinate pairs for each location, and average them out before comparing the current location. This still risks some dirty data getting us wrong guesses, but those can be edited manually until we have sufficient data.
Get gps coords for each location. Guess current location from gps