Closed Snurppa closed 2 years ago
@heikkipora updated package-lock.json. There was a backport fix to jsprim which fixed audit issue that previously failed pipeline had: https://github.com/joyent/node-jsprim/releases/tag/v1.4.2
edit: I initially started to see if shrinkwrap would've been the way to fix it, but in the meantime that backport was released so in the end just updating with npm i
was enough.
I also tested manually that the Less middleware was picking CSS changes correctly.
Thanks for the PR, looks good. I have one request though: please document the new configuration property in the appropriate README.md section also.
Thanks for the PR, looks good. I have one request though: please document the new configuration property in the appropriate README.md section also.
It is not a configuration in this app, but in GitLab itself. The default branch is taken from the API response. It can vary between GitLab projects.
There is currently no support for per project configuration in this app. But luckily that was not necessary as the relevant config value comes from GitLab. It would have been bigger PR to add project level configuration to the YAML 😃
Oh, true indeed - dunno how I missed that :-)
And it's released as part of https://github.com/heikkipora/gitlab-radiator/releases/tag/v3.3.10
Created some issues where 'main' was used as default branch - status for many project was 'undefined' because no pipelines were left after applying the ref: 'master' filter.
ref: communities are moving from master to main https://github.com/github/renaming
Maybe your integration-test suite could add a project into GitLab with different default branch to add new test with "other than master" case.