heimdalljs / heimdalljs

Instrumentation for JavaScript Applications
50 stars 13 forks source link

[epic] reverting 0.3 changes and layering on features with backward compatibility. #128

Open gabrielcsapo opened 4 years ago

gabrielcsapo commented 4 years ago

0.3 had a bunch of great features that were added for the format that was produced.

There have been issues with it's compatibility within the ecosystem and I suggest we do the following;

  1. revert 0.3 changes and go back to 0.2.6 (https://github.com/heimdalljs/heimdalljs/commit/43d1ac2fff006e905a85a0a5cdf9cb9f7bf54c67) (this would be a major bump to 1.0.0)
  2. identify a backwards compatible way to output a standard profiling output
  3. update all consumers of heimdall (ember*) to the latest 1.0.0 release to ensure backwards compatibility testing against 1.0.0 targets for any future looking changes.

Current consumers of ^0.3

cc. @stefanpenner @hjdivad

hjdivad commented 4 years ago

@gabrielcsapo keep in mind that ember-data is a consumer of the 0.3 API

gabrielcsapo commented 4 years ago

@hjdivad made a note of the two consumers that I have found using the 0.3 API

runspired commented 1 year ago

tbh it would be trivial still to move 0.2.3/0.2.4 consumers onto 0.3. The 0.2 format just doesn't make sense at all. Ideally now that node has advanced to having performance timing APIs as well we could just use performance.mark for everything and be done with it.