search

heimrichhannot / contao-google-maps-bundle

This bundle adds google maps integration to Contao.
2 stars 8 forks source link

add support for Contao Consent #12

Closed frontendschlampe closed 2 years ago

frontendschlampe commented 3 years ago

Hey, we would provide a PR to support our commercial extension Contao Consent, so that the website editor just need to choose a service provider for prevent loading Google Maps without any consent given.

Is that ok for you?

Defcon0 commented 3 years ago

Would it also be an option that we dispatch event so that you can do your changes this way? How would your integration look like?

dmolineus commented 3 years ago

We provide a bridge extension which abstracts the integration of the consent tool and can be used by any consent tools. The goal of the bridge is to fill the gap between extension developers and consent tools providers. The basic support is enabled by a simple plugin class. A more advanced integration, for example for a placeholder in a partial of the module/content element might require template changes.

An example of the plugin can be found here: https://github.com/hofff/contao-tawk-to/blob/master/src/ConsentBridge/Plugin.php

The dependency of the consent bridge can be defined as an optional requirements also.

Defcon0 commented 3 years ago

The less code the better, so your concept of a bridge module sounds reasonable.

Please provide a PR and we'll check if we can integrate it.

frontendschlampe commented 2 years ago

Hey @Defcon0 we made a PR here https://github.com/heimrichhannot/contao-google-maps-bundle/pull/17

Defcon0 commented 2 years ago

New version is there: 2.5.0 :+1:

Thanks!