search

heimrichhannot / contao-utils-bundle

This bundle offers various utility functionality for the Contao CMS.
GNU Lesser General Public License v3.0
8 stars 4 forks source link

fixed hours transform assignement #31

Closed AlexejKossmann closed 3 years ago

AlexejKossmann commented 3 years ago

The correct hours itransformation to iso8601 H => hh. See See https://www.w3.org/TR/NOTE-datetime

My concern is thats not save to change it.

@Defcon0 what do you think about this?

Defcon0 commented 3 years ago

If it's a bug, it's no BC break. After a short research, it seems that you're right. So I guess, it should be ok to change it if it's a bug anyway. Have you tested it with our common modules (flatpickr, filter, formhybrid)?

AlexejKossmann commented 3 years ago

If it's a bug, it's no BC break. After a short research, it seems that you're right. So I guess, it should be ok to change it if it's a bug anyway. Have you tested it with our common modules (flatpickr, filter, formhybrid)?

Yes, i have tested it on flatpickr with formhybrid, its allways applied by the twig-templates-bundle EventListener.

So i think it will be applied on everything

Defcon0 commented 3 years ago

Could you please also test it in filter-bundle? If that also works, I'm ok with it ;-)