search

heimseiten / contao-article-list-with-css-classes-and-ids-bundle

1 stars 0 forks source link

Contao 5.3 issue #1

Open ThePatzen opened 5 months ago

ThePatzen commented 5 months ago

Hi!

Since Contao 5.2 using $GLOBALS['TL_CSS'] with scss does not work anymore! As workaround you could use the following:

$objCombiner = new Contao\Combiner();
$objCombiner->add(<SCSSFILE>);
$GLOBALS['TL_CSS'][] = $objCombiner->getCombinedFile();
heimseiten commented 5 months ago

Hi, are you sure? I am using it with 5.3 and it seems to work. See:

https://docs.contao.org/dev/framework/asset-management/

ThePatzen commented 5 months ago

Hi! Yes! Testet it for hours to find the Problem :-)

Since 5.2.0 Bundler, which converts SCSS to CSS in backend, ist not used anymore! So you deliver the SCSS file to the user instead of the compiled css.

Here you can see the 5.1.x Version: https://github.com/contao/contao/blob/aa27794f26582b450d46f5d43d87386271e720f5/core-bundle/contao/templates/backend/be_main.html5#L15C5-L25C9

And the 5.3.x Version: https://github.com/contao/contao/blob/28c37794bb8ea3e23876a99b4b8eada121f8d3a8/core-bundle/contao/templates/backend/be_main.html5#L15C1-L19C101

I hope this helps!

heimseiten commented 5 months ago

Thank you very much. I'll try to change it when I find the time. If you like, you are welcome to make a pull request.