heinrich5991 / libtw2

Some Teeworlds stuff in Rust.™
Apache License 2.0
50 stars 16 forks source link

wireshark-dissector: Make the dissector for snapshots much more granular. #54

Open C0D3D3V opened 2 years ago

C0D3D3V commented 2 years ago

So that one can distinguish e.g. whether it is a CNetObj_EntityEx or CNetObj_Laser. Further it would be great if the individual data within a snapshot are named, as for example with a CNetObj_Laser (https://github.com/C0D3D3V/ddnet/blob/bc80d83ec9ad929d7f36774d2a2391379c40ffcd/datasrc/network.py#L123-L130):

miguilimzero commented 9 months ago

This would be really useful!

ChillerDragon commented 4 months ago

Snap single should be fine. It will be in diffs and not the actual values. So m_X will not be the actual position but the diff to the last position. Thats still nice to see.

But regular snaps (partial snaps) will be messy. The first part might cut in the middle of a snap item. The 2nd and later parts might start their payload in the middle of a snap item. I am not sure if wireshark supports cross packet context and how smooth that could be integrated with libtw2.

heinrich5991 commented 4 months ago

Wireshark supports reassembly of split packets: https://www.wireshark.org/docs/wsdg_html_chunked/ChDissectReassemble.html.